Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Ensure active file list entry is highlighted #45594

Merged
merged 3 commits into from
May 31, 2024
Merged

fix(files): Ensure active file list entry is highlighted #45594

merged 3 commits into from
May 31, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented May 30, 2024 •
edited by AndyScherzinger
Loading

Summary

Make sure the entry with the fileid (from route) is highlighted.

Screenshots

before after
Screenshot_20240530_225623 Screenshot_20240530_225601

Checklist

@susnux susnux added this to the Nextcloud 30 milestone May 30, 2024
@susnux susnux requested a review from skjnldsv as a code owner May 30, 2024 20:59
@susnux
Copy link
Contributor Author

susnux commented May 30, 2024

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented May 30, 2024

/backport to stable29

Pytal
Pytal approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 🚀

@susnux @AndyScherzinger
fix(files): Ensure entry with fileid is marked as active
7c4dcf5 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @AndyScherzinger
refactor(files): Consistently sort imports of FileEntryMixin
2c47f24 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@AndyScherzinger
Copy link
Member

/compile /

@nextcloud-command
chore(assets): Recompile assets
a755651 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux susnux merged commit 4a6ac1f into master May 31, 2024
104 checks passed
@susnux susnux deleted the fix/files-active-entry branch May 31, 2024 10:17
This was referenced May 31, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@Pytal Pytal Pytal approved these changes

@artonge artonge Awaiting requested review from artonge

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@szaimen szaimen Awaiting requested review from szaimen

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @AndyScherzinger @Pytal @nextcloud-command