Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump select2 from v3 to v4 #45628

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

drjoeycadieux
Copy link

I update the select2 version to 4.0.8 in the package.json

  • Resolves: #

Summary

TODO

  • ...

Checklist

I update the select2 version to 4.0.8 in the package.json

Signed-off-by: Joey Cadieux <instructor.joeycadieux@gmail.com>
@ChristophWurst
Copy link
Member

See #35294

@ChristophWurst ChristophWurst marked this pull request as draft June 3, 2024 06:04
@ChristophWurst ChristophWurst changed the title Update package.json Bump select2 from v3 to v4 Jun 3, 2024
@drjoeycadieux drjoeycadieux marked this pull request as ready for review June 5, 2024 14:30
@skjnldsv
Copy link
Member

skjnldsv commented Jun 7, 2024

I think we're removing it as legacy code 🙈
@susnux ?

@susnux
Copy link
Contributor

susnux commented Jun 7, 2024

Yes we are currently removing the last places where it is used. I would not updated this package untested as it currently might break user ldap and other legacy stuff.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@solracsf solracsf added this to the Nextcloud 30 milestone Jun 18, 2024
@drjoeycadieux
Copy link
Author

Sorry, I'm here.

@blizzz blizzz mentioned this pull request Jul 30, 2024
@joshtrichards
Copy link
Member

Related overview: #1831 (though it looks to need updating)

@blizzz blizzz mentioned this pull request Aug 1, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants