-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump select2 from v3 to v4 #45628
base: master
Are you sure you want to change the base?
Bump select2 from v3 to v4 #45628
Conversation
I update the select2 version to 4.0.8 in the package.json Signed-off-by: Joey Cadieux <instructor.joeycadieux@gmail.com>
See #35294 |
I think we're removing it as legacy code 🙈 |
Yes we are currently removing the last places where it is used. I would not updated this package untested as it currently might break user ldap and other legacy stuff. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Sorry, I'm here. |
Related overview: #1831 (though it looks to need updating) |
I update the select2 version to 4.0.8 in the package.json
Summary
TODO
Checklist