Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings): Emit loaded event for user management #45685

Merged
merged 2 commits into from
Jun 18, 2024
Merged

feat(settings): Emit loaded event for user management #45685

merged 2 commits into from
Jun 18, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 5, 2024

Summary

  • Required so that we can wait until OCA.Settings.UserList is fully initialized before attempting to register an action

Checklist

@Pytal Pytal added this to the Nextcloud 30 milestone Jun 5, 2024
@Pytal Pytal requested review from susnux, Fenn-CS and skjnldsv June 5, 2024 22:00
@Pytal Pytal self-assigned this Jun 5, 2024
@Pytal

This comment was marked as outdated.

Sign in to view
@Pytal Pytal mentioned this pull request Jun 14, 2024
Merged
skjnldsv
skjnldsv approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@icewind1991

This comment was marked as outdated.

Sign in to view
@Pytal
feat(settings): Emit loaded event for user management
e1e607a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Jun 18, 2024

/compile /

@Pytal Pytal enabled auto-merge June 18, 2024 18:35
@nextcloud-command
chore(assets): Recompile assets
68b2b84 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal merged commit a358717 into master Jun 18, 2024
109 checks passed
@Pytal Pytal deleted the feat/emit-users-loaded branch June 18, 2024 18:58
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews enhancement feature: users and groups
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @icewind1991 @susnux @skjnldsv @nextcloud-command