-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(preview): ffmpeg gets stuck when getting video cover #45722
Conversation
Fixed the issue that ffmepg was stuck in getting the cover, which caused the PHP process to be blocked. Signed-off-by: ncheng89 <48044818+ncheng89@users.noreply.github.com>
Good idea to make the movie preview provider more robust by adding a timeout. I used ffmpeg cannot extract an image for the given file. The timeout might help to reduce the impact, but Nextcloud will try to generate the preview again and again and again. We could also use the symfony process component (it's in 3rdparty) that provides this timeout logic already. Related: #42545 |
Of course, this fix includes the ffmpeg timeout problem. If ffmpeg fails to obtain the cover within the specified time, the task will be terminated and the ffmpeg process will be recycled and released. |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixed the issue that ffmepg was stuck in getting the cover, which caused the PHP process to be blocked.
Summary
TODO
Checklist