Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace icons with latest Material Symbol versions #45755

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Replace icons with latest Material Symbol versions #45755

merged 6 commits into from
Jun 10, 2024

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jun 10, 2024 •
edited
Loading

Summary

TODO

  • visual review from designers
  • optimize svg files
  • compile icon.css
  • review and merge

Checklist

@AndyScherzinger AndyScherzinger added design Design, UI, UX, etc. 2. developing Work in progress labels Jun 10, 2024
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Jun 10, 2024
@AndyScherzinger
Copy link
Member Author

https://github.com/nextcloud/server/pull/45755/files#diff-400d26bc489aa2e67324c88e3930cffa372a501af3be65f3cd4867689f4aef1c has been changed in the former PR and is now reverted back to the group icon, for consistency

jancborchardt
jancborchardt requested changes Jun 10, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments inline, other icons look good! :)

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx-batch15 branch 5 times, most recently from 501dc57 to 8e91908 Compare June 10, 2024 15:53
@AndyScherzinger
chore: Replace icons with latest Material Design versions
e6d6853 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Update license infos
74aa004 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: update mastodon icon with original resource
38202c0 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
chore: Add further media resource license info items
83e85f4 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member Author

/compile /

@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 10, 2024
@AndyScherzinger AndyScherzinger changed the title Replace icons with latest Material Design versions Replace icons with latest Material Symbol versions Jun 10, 2024
@AndyScherzinger AndyScherzinger changed the title Replace icons with latest Material Symbol versions Replace icons with latest *Material Symbol* versions Jun 10, 2024
@AndyScherzinger AndyScherzinger changed the title Replace icons with latest *Material Symbol* versions Replace icons with latest Material Symbol versions Jun 10, 2024
nextcloud-command and others added 2 commits June 10, 2024 16:45
@nextcloud-command
chore(assets): Recompile assets
2cd4449 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger
chore: Update comments app icon
cca4978 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger merged commit 44ed10d into master Jun 10, 2024
109 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/spdx-batch15 branch June 10, 2024 17:20
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@susnux susnux Awaiting requested review from susnux

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. technical debt
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Substitute icons by Material Design ones?
4 participants
@AndyScherzinger @jancborchardt @miaulalala @nextcloud-command