Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caldav): event links in shared calendar notifications #45775

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jun 11, 2024

Summary

The link in event notifications is invalid if a calendar is shared. An incoming shared calendar is belonging to sharee's principal with the custom name <calendar>_shared_by_<sharer>.

I implemented a hack to change the link in those cases to make the links in notifications work again.

How to reproduce the bug?

  1. Have 2 users: admin and user
  2. Install and enable the Calendar app.
  3. Log in as user and enable all push notifications regarding calendars (see screenshot below).
  4. Log in as admin.
  5. Create a calendar and share it with user.
  6. Create an event in the calendar.
  7. Log in as user.
  8. Open the notifications (on the top right) and click on the event link.

Here: Clicking the link redirects to Calendar and opens the event.
Master: Clicking the link redirects to Calendar and shows an empty content Event does not exist.

grafik

Checklist

@st3iny st3iny added bug 3. to review Waiting for reviews feature: activity and notification feature: caldav Related to CalDAV internals labels Jun 11, 2024
@st3iny st3iny added this to the Nextcloud 30 milestone Jun 11, 2024
@st3iny st3iny self-assigned this Jun 11, 2024
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@st3iny
Copy link
Member Author

st3iny commented Jun 11, 2024

/backport to stable29

@st3iny
Copy link
Member Author

st3iny commented Jun 11, 2024

/backport to stable28

@st3iny
Copy link
Member Author

st3iny commented Jun 11, 2024

/backport to stable27

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 11, 2024
@st3iny st3iny enabled auto-merge June 11, 2024 17:03
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: activity and notification feature: caldav Related to CalDAV internals
Projects
Development

Successfully merging this pull request may close these issues.

Shared calendar: links from mail or notifications to events broken
3 participants