feat(core): add selection for recommended apps

[sanskar-soni-9]

• Resolves: Check/Uncheck button to install specific recommended app from "/apps/recommended" page #45084

Summary

Added functionality to selectively install recommended apps

Before

After

2024-06-11.14-45-42.online-video-cutter.com.mp4

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[sanskar-soni-9]

I need opinion for this arrow should I remove it?

[susnux]

I need opinion for this arrow should I remove it?

I would say yes.

[sanskar-soni-9]

I need opinion for this arrow should I remove it?

arrow?!, I meant icon 😅, anyways removed!

[sanskar-soni-9]

Now looking at the diff I think it can be there can be more solutions for it, like adding another state variable for selected app ids instead of introducing new property in all apps or something similar, in any case pls let me know if any approach is more preferred here

[jancborchardt]

Very nice! Just some feedback:

• All apps should be pre-checked to be selected, at least the ones which are compatible (which on a release should be all of them)
• If none is selected, the buttons below can be disabled rather than hidden to prevent jumping of the interface
• Checking and unchecking of the box shouldn’t need a spinner, since the installing/downloading is only in the next step? Checking/unchecking should be instant

Nice work @sanskar-soni-9! :)

[sanskar-soni-9]

Thanks @jancborchardt, and checking/unchecking is instant I am using checkbox loading state as an indicator that which app is downloading/installing which I think looks better and cleaner, so I removed previous spinner and installed check icon and overloaded checkbox for every state/step:

1. when user will select app to install checkbox will be blue and enabled
2. then when he will click on install button then loading checkbox will indicate which app is currently getting installed
3. and then when app will be installed the checkbox will be disabled and will indicate that the app is installed

I can always bring back previous spinner and check icon if that is needed?

[sanskar-soni-9]

Here is the updated UI flow:

2024-06-15.17-13-40.mp4

Current UI shift is due to installing status line which get added when apps are installing

and I still kept loading checkbox because of the previous reason so please let me know your review on this

[jancborchardt]

Awesome, really nice @sanskar-soni-9, and thanks for the explanation! :)

Current UI shift is due to installing status line which get added when apps are installing

I would recommend to put this line next to the "Install recommended apps" button, or better yet change the button to "Installing apps …", cause up there the line is not really visible, and then also the layout does not shift. :)

[sanskar-soni-9]

@jancborchardt done! 😃

[jancborchardt]

Looks good design-wise now! :) But has to be checked regarding code.

[susnux]

🚀

[susnux]

Can you rebase onto current master?

[sanskar-soni-9]

@susnux done :)

[sanskar-soni-9]

Oops I forgot about this and deleted the repo, new PR in progress