Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(files): Use @nextcloud/files functions where possible and make files views cancelable #45788

Merged
merged 7 commits into from
Jun 11, 2024
Merged

refactor(files): Use @nextcloud/files functions where possible and make files views cancelable #45788

merged 7 commits into from
Jun 11, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 11, 2024 •
edited
Loading

Summary

  1. Use the functions from @nextcloud/files where possible, replaces a lot of duplicated code in the files views.
  2. Make the getContents functions cancelable to possibly save some network requests
  3. Fix the favorites ⭐ view by adding a fake root like for recent etc, because you shall not be able to upload to the "favorites" root.

Checklist

@susnux susnux requested a review from skjnldsv as a code owner June 11, 2024 12:57
@susnux susnux added bug 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) feature: files and removed bug labels Jun 11, 2024
@susnux susnux added this to the Nextcloud 30 milestone Jun 11, 2024
@susnux susnux requested review from artonge, Fenn-CS and Pytal June 11, 2024 13:06
@susnux
refactor(systemtags): Do not link to files app but directly use funct…
9ea557e 
…ions from `@nextcloud/files`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(files): Migrate files service to functions from `@nextcloud/…
85e6cb4 
…files`

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(files): Migrate recent view to @nextcloud/files function…
b1444e7 
…s and make it cancelable

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(files): Migrate favorites view to @nextcloud/files funct…
de2276e 
…ions and make it cancelable

Also this fixes the view being writeable

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(files): Migrate personal view to @nextcloud/files functions
5332482 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files): Adjust babel module resolution
8fc828e 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
8a3f964 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit bac37b1 into master Jun 11, 2024
109 checks passed
@susnux susnux deleted the refactor/files-library branch June 11, 2024 19:25
@susnux susnux mentioned this pull request Jun 13, 2024
Merged
4 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv left review comments

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Numerical accounts show all files/folders in "Shared" status in the web UI
4 participants
@susnux @artonge @skjnldsv @Pytal