Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix(Session): avoid password confirmation on SSO #45812

Merged
merged 4 commits into from
Jun 18, 2024
Merged

[stable26] fix(Session): avoid password confirmation on SSO #45812

merged 4 commits into from
Jun 18, 2024

Commits on Jun 12, 2024

  1. fix(Session): avoid password confirmation on SSO 

    SSO backends like SAML and OIDC tried a trick to suppress password
confirmations as they are not possible by design. At least for SAML it was
not reliable when existing user backends where used as user repositories.

Now we are setting a special scope with the token, and also make sure that
the scope is taken over when tokens are regenerated.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    eea5e1c View commit details
    Browse the repository at this point in the history

  2. fix(Token): make new scope future compatible 

    - "password-unconfirmable" is the effective name for 30, but a draft
  name was backported.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    0f5c8f9 View commit details
    Browse the repository at this point in the history

  3. style(PHP): remove unacceptable empty lines 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    06c64fd View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2024

  1. test(unit): adjust testSSO scenario and test class 

    Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
    @blizzz
    blizzz committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    527bc5d View commit details
    Browse the repository at this point in the history