Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add new clickable area variables #45818

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Feat: add new clickable area variables #45818

merged 2 commits into from
Jun 14, 2024

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Jun 12, 2024 •
edited
Loading

Add new variables for clickable areas and reduces size of --default-clickable-area

Part of #45657

@marcoambrosini
Feat: add new clickable area variables
68cba58 
Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
@marcoambrosini marcoambrosini mentioned this pull request Jun 10, 2024
Closed
7 tasks
@marcoambrosini marcoambrosini self-assigned this Jun 12, 2024
@marcoambrosini marcoambrosini added the 3. to review Waiting for reviews label Jun 12, 2024
@marcoambrosini marcoambrosini added the design Design, UI, UX, etc. label Jun 12, 2024
@skjnldsv skjnldsv removed their request for review June 12, 2024 14:57
susnux
susnux approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep the large clickable area at 44px, but either way ok for me :)

@marcoambrosini @susnux
Feat: Update apps/theming/lib/Themes/DefaultTheme.php
fddb2f0 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Marco <marcoambrosini@proton.me>
jancborchardt
jancborchardt reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should clickable-area-large not be 44px, so we don't make elements even bigger?

@marcoambrosini marcoambrosini merged commit 018a0ae into master Jun 14, 2024
165 checks passed
@marcoambrosini marcoambrosini deleted the feat/add-new-clickable-area-variables branch June 14, 2024 07:31
@marcoambrosini
Copy link
Member Author

@jancborchardt sorry I missed your comment, I thought it'd be good to boost it a bit since it would be only one button per app basically. This would be also in line with what google and dropbox do. But we can see how it looks and dial it back before release in case it's too much

@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Jun 14, 2024
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jun 21, 2024
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@jancborchardt jancborchardt jancborchardt left review comments

@artonge artonge artonge approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews design Design, UI, UX, etc. pending documentation This pull request needs an associated documentation update
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoambrosini @jancborchardt @AndyScherzinger @susnux @artonge @ChristophWurst