fix: rename split into two as before rename and after rename #45845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyteinsky
reviewed
Jun 13, 2024
kyteinsky
approved these changes
Jun 13, 2024
artonge
approved these changes
Jun 13, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
artonge
reviewed
Jun 13, 2024
artonge
requested changes
Jun 13, 2024
artonge
approved these changes
Jun 17, 2024
… getInternalPath is used in place of getPath to make it consistent across the logs Signed-off-by: yemkareems <yemkareems@gmail.com>
… to have one log for rename event Signed-off-by: yemkareems <yemkareems@gmail.com>
…as suggested in review comments Signed-off-by: yemkareems <yemkareems@gmail.com>
yemkareems
force-pushed
the
fix/log-rename-to-use-internal-path
branch
from
1a4e3d0
to
eae2386
Compare
kyteinsky
added
bug
feature: admin audit
and removed
3. to review
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename logged as beforeRename and afterRename, and in both placegetInternalPath is used in place of getPath to make it consistent across the logs
The new log entry is
{"reqId":"UWHQDoQKdUhE5aX27rdE","level":1,"time":"2024-06-13T12:02:04+00:00","remoteAddr":"192.168.21.5","user":"admin","app":"admin_audit","method":"MOVE","url":"/remote.php/dav/files/admin/nc.logs.txt","message":"File renamed with id "2263" from "/nc.logs.txt" to "/nc2.logs.txt"","userAgent":"Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36","version":"30.0.0.1","data":{"app":"admin_audit"}}
Summary
TODO
Checklist