Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comments): Use proper icon components instead of icon classes to fix dark mode #45867

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 13, 2024

Summary

When using the comments app with dark mode the icons are hard to see because they are all black.
This is fixed with using proper icon components.

Screenshots

before after
Screenshot 2024-06-13 at 18-06-37 Files - Nextcloud Screenshot 2024-06-13 at 18-12-13 img_3236 jpg - Nextcloud

Checklist

…fix dark mode

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 30 milestone Jun 13, 2024
@susnux
Copy link
Contributor Author

susnux commented Jun 13, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Jun 13, 2024

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented Jun 13, 2024

/compile

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 13, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
Copy link
Member

Awesome!!

@solracsf
Copy link
Member

solracsf commented Jul 11, 2024

@skjnldsv @susnux should this be re-backported to stable28 ?
Ref: #45881 and #45881 (comment)

@susnux
Copy link
Contributor Author

susnux commented Jul 15, 2024

/backport to stable28

@skjnldsv
Copy link
Member

/backport to stable28

Copy link

backportbot bot commented Jul 27, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/45867/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 93650e08 f8095023

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45867/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45867/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants