tests(settings): Fix AccountMigratorTest when using PNG avatars #45883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
SystemKeeper
approved these changes
Jun 14, 2024
blizzz
approved these changes
Jun 14, 2024
PNG is lossless so we test the imported file for equality with the exported file, but the changed asset was never imported into Nextcloud so it was never initially scaled. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Altahrim
approved these changes
Jun 14, 2024
blizzz
added
4. to release
6 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PNG is lossless so we test the imported file for equality with the exported file, but the changed asset was never imported into Nextcloud so it was never initially scaled.
(was introduced with #45810 )
Checklist