-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move repair mimetype repair step to the expensive steps #45930
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
/backport to stable29 |
/backport to stable28 |
Not ideal. Adding mime types to existing files can be important to make certain functionality work. Could you add a hint to |
|
dbfd000
to
5a56726
Compare
Thank you 👍 |
5a56726
to
262811f
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
262811f
to
e74f71b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we would split the operations that are performed for the new mimetype:
The insert into oc_mimetypes could be still in regular migration steps as it is just one insert for a new mimetype, that way it will already work for new files: https://github.com/nextcloud/server/blob/repair-mimetype-expensive/lib/private/Repair/RepairMimeTypes.php#L42-L44
Otherwise 👍
There is no need to preemptively insert the rows into The only thing required for new files to work is the mimetype mapping being updated, and that is part of the source upgrade. |
redoing the other backports based on the 29 one |
/backport to stable27 |
Looking through the entire filecache takes a while