Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprecated legacy search backend #45950

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jun 18, 2024

Summary

While further checking #44951 I noticed that the old search endpoint in core is marked as deprecated and not used anywhere anymore. Files was also the only app left registering a provider.

Further the app had no route left anyways.

Was deprecated in Nextcloud 20 so good to remove.

Checklist

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@kesselb kesselb added the pending documentation This pull request needs an associated documentation update label Jun 18, 2024
@kesselb
Copy link
Contributor

kesselb commented Jun 18, 2024

Don't forget to update https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.html.

@blizzz blizzz mentioned this pull request Jul 30, 2024
@juliushaertl juliushaertl force-pushed the chore/remove-depreacted-search branch from 8a6e0d1 to 95925cd Compare August 1, 2024 09:11
@blizzz blizzz mentioned this pull request Aug 1, 2024
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl force-pushed the chore/remove-depreacted-search branch from 95925cd to a6d421e Compare August 1, 2024 10:33
@AndyScherzinger AndyScherzinger merged commit 014fcb0 into master Aug 1, 2024
169 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/remove-depreacted-search branch August 1, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants