-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove deprecated legacy search backend #45950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
force-pushed
the
chore/remove-depreacted-search
branch
from
June 18, 2024 11:53
d01fa2e
to
fa09c45
Compare
24 tasks
juliushaertl
force-pushed
the
chore/remove-depreacted-search
branch
from
June 18, 2024 12:05
fa09c45
to
8a6e0d1
Compare
ChristophWurst
approved these changes
Jun 18, 2024
kesselb
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
kesselb
added
the
pending documentation
This pull request needs an associated documentation update
label
Jun 18, 2024
nickvergessen
approved these changes
Jun 19, 2024
come-nc
approved these changes
Jun 20, 2024
Merged
juliushaertl
force-pushed
the
chore/remove-depreacted-search
branch
from
August 1, 2024 09:11
8a6e0d1
to
95925cd
Compare
Merged
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
chore/remove-depreacted-search
branch
from
August 1, 2024 10:33
95925cd
to
a6d421e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
pending documentation
This pull request needs an associated documentation update
technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While further checking #44951 I noticed that the old search endpoint in core is marked as deprecated and not used anywhere anymore. Files was also the only app left registering a provider.
Further the app had no route left anyways.
Was deprecated in Nextcloud 20 so good to remove.
Checklist