Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use guzzle for addressbook federation #46002

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 20, 2024

  • Resolves: noid

Summary

  • Use guzzle as http client
  • Don't mock the service itself, but the dependencies.

TODO

  • CI
  • Review

Checklist

@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Jun 20, 2024
@kesselb kesselb added this to the Nextcloud 30 milestone Jun 20, 2024
@kesselb kesselb self-assigned this Jun 20, 2024
@kesselb kesselb force-pushed the debt/noid/use-new-http-client branch from f5cba2e to 36b5ba6 Compare June 20, 2024 10:12
@kesselb kesselb force-pushed the debt/noid/use-new-http-client branch from 36b5ba6 to 4cf184b Compare June 20, 2024 11:00
@kesselb kesselb force-pushed the debt/noid/use-new-http-client branch from 4cf184b to 85b0772 Compare June 20, 2024 14:03
The request method is available since 29 and thus we can finally use the modern http client to send the report request for the addressbook sync.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the debt/noid/use-new-http-client branch from 85b0772 to f73c5c4 Compare June 25, 2024 10:24
@kesselb kesselb merged commit 9522719 into master Jun 25, 2024
165 checks passed
@kesselb kesselb deleted the debt/noid/use-new-http-client branch June 25, 2024 19:10
@kesselb
Copy link
Contributor Author

kesselb commented Jun 25, 2024

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants