Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rmdir() to release possible directory lock prior to removing directory #46027

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

dennisverspuij
Copy link
Contributor

As described in this Nextcloud community issue some storage systems (such as VirtualBox shared folders) may lock a directory when traversing it using opendir() or a DirectoryIterator. This patch fixes Local::rmdir() to release such locks prior to removing a directory recursively, avoiding failure to do so with 'Text file busy" warnings.

This PR replaces 45967 I messed up, sorry for that.

@solracsf solracsf added this to the Nextcloud 30 milestone Jun 21, 2024
@solracsf solracsf added the 3. to review Waiting for reviews label Jun 21, 2024
@solracsf

This comment was marked as resolved.

@dennisverspuij dennisverspuij force-pushed the virtualbox-storage-fix branch from 2fc779e to a275497 Compare June 21, 2024 22:03
Copy link
Contributor

github-actions bot commented Jul 6, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

…ock prior to deleting a directory, to avoid e.g. "Text file busy" error with VirtualBox shared folder storage

Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the virtualbox-storage-fix branch from e70fcf7 to 181aeca Compare July 27, 2024 14:43
@skjnldsv skjnldsv merged commit 0525312 into nextcloud:master Jul 27, 2024
96 of 103 checks passed
Copy link

welcome bot commented Jul 27, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@blizzz blizzz mentioned this pull request Jul 30, 2024
@dennisverspuij dennisverspuij deleted the virtualbox-storage-fix branch August 21, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants