fix(ExternalSharing): Handle template shares from external sources #46068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
fix/guest-share-ui-update
branch
2 times, most recently
from
0168a8b
to
45da8a0
Compare
artonge
approved these changes
Jun 24, 2024
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
nfebe
changed the title
nfebe
force-pushed
the
fix/guest-share-ui-update
branch
from
45da8a0
to
3b7883d
Compare
|
@nextcloud/server-frontend |
nfebe
added
3. to review
susnux
approved these changes
Jul 2, 2024
The new sharing flow requires or implies that users should edit share before creating. External sources should not created the share IF we would upon sharing details tab on first request. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
The new sharing flow since NC27 requires that users open the sharing details tab and customize their share before creating it. In #39472 the work of `addShare` was handed down to `openSharingDetails` that opens the sharing details tab for the user to customize and manually creat their share. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/guest-share-ui-update
branch
from
1cb0924
to
483d857
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Jul 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update UI correctly upon guest invite.
The new sharing flow requires or implies that users should edit share before creating.
External sources should not created the share IF we would upon sharing details tab on first request.
The new sharing flow since NC27 requires that users open the sharing details tab and
customize their share before creating it.
In #39472 the work of
addSharewas handed down toopenSharingDetailsthat opens the sharing details tab for the user to customize and manuallycreat their share.
Related : nextcloud/guests#1189
TODO