Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Token): add FILESYSTEM scope with SCOPE_SKIP_PASSWORD_VALIDATION #46071

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jun 24, 2024

Summary

The scope design requires scopes to be either not specified, or
specified explicitely. Therefore, when setting the
skip-password-validation scope for user authentication from mechanisms
like SAML, we also have to set the filesystem scope, otherwise they will
lack access to the filesystem.

Checklist

The scope design requires scopes to be either not specified, or
specified explicitely. Therefore, when setting the
skip-password-validation scope for user authentication from mechanisms
like SAML, we also have to set the filesystem scope, otherwise they will
lack access to the filesystem.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added bug 3. to review Waiting for reviews labels Jun 24, 2024
@blizzz blizzz added this to the Nextcloud 30 milestone Jun 24, 2024
@blizzz blizzz requested review from icewind1991, juliusknorr, julien-nc, a team, ArtificialOwl, yemkareems and ChristophWurst and removed request for a team June 24, 2024 11:53
@blizzz
Copy link
Member Author

blizzz commented Jun 24, 2024

/backport to stable29

@blizzz
Copy link
Member Author

blizzz commented Jun 24, 2024

/backport to stable28

@blizzz
Copy link
Member Author

blizzz commented Jun 24, 2024

/backport to stable27

@blizzz
Copy link
Member Author

blizzz commented Jun 24, 2024

/backport to stable26

@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 24, 2024
@blizzz blizzz merged commit 879eaa7 into master Jun 24, 2024
165 checks passed
@blizzz blizzz deleted the fix/46070/scope-error branch June 24, 2024 13:21
Copy link

backportbot bot commented Jun 24, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/46071/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 895ed634

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46071/stable26

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jun 24, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/46071/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 895ed634

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46071/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jun 24, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/46071/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 895ed634

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46071/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jun 24, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/46071/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 895ed634

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46071/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzz
Copy link
Member Author

blizzz commented Jun 24, 2024

backports will not have the constant

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SAML users without file access in 29.0.3rcX, 28.0.7rcX, 27.1.11rcX
4 participants