Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined BackgroundCleanupJob queries for robustness, allowing CACHEDIR.TAG in preview root #46072

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dennisverspuij
Copy link
Contributor

I personally like NextCloud AIO to exclude previews from backup, by adding a appdata_*/preview/CACHEDIR.TAG file.
However the queries of the \OC\Preview\BackgroundCleanupJob (may) fail because of this,
This PR fixes this by making the queries more precise.

…R.TAG in preview root

Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>
@kesselb
Copy link
Contributor

kesselb commented Jun 24, 2024

Related: #42540

Haven't tested it but looks reasonable.

I am not sure if I like the idea of having unrelated files there, but I see the use case.

@kesselb kesselb added enhancement 3. to review Waiting for reviews labels Jun 24, 2024
@kesselb kesselb added this to the Nextcloud 30 milestone Jun 24, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

This was referenced Jul 30, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants