Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(files): Migrate logger to Typescript #46083

Merged
merged 3 commits into from
Aug 1, 2024
Merged

refactor(files): Migrate logger to Typescript #46083

merged 3 commits into from
Aug 1, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 24, 2024 •
edited
Loading

  1. This is just a tiny rename to make our files code base more consistent by using Typescript where possible.
  2. Plus another small refactor to fix invalid doc block and resort imports

@susnux susnux added 3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jun 24, 2024
@susnux susnux added this to the Nextcloud 30 milestone Jun 24, 2024
@susnux susnux requested review from artonge and Pytal June 24, 2024 22:15
@susnux susnux requested a review from skjnldsv as a code owner June 24, 2024 22:15
Pytal
Pytal reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it a named export?

@susnux
Copy link
Contributor Author

susnux commented Jun 25, 2024

Maybe make it a named export?

In general I would agree, here it is so small and single use-case, so both work. I have not strong opinion on either of them.
Meaning I can do so if that is preferred 😅

@susnux
Copy link
Contributor Author

susnux commented Jun 25, 2024

/compile

@susnux susnux enabled auto-merge June 25, 2024 23:20
@blizzz blizzz mentioned this pull request Jul 30, 2024
Merged
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 30, 2024
@susnux susnux force-pushed the refactor/files-logger branch 2 times, most recently from 387fba4 to 20fec15 Compare July 30, 2024 20:19
@susnux
refactor(files): Migrate logger util to Typescript
172c433 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
refactor(files): Resort imports and fix doc comment
1b9d619 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @skjnldsv
chore: Compile assets
cffe37e 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 20adbd1 into master Aug 1, 2024
111 checks passed
@susnux susnux deleted the refactor/files-logger branch August 1, 2024 05:30
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @artonge @skjnldsv @Pytal