fix: Add acceptShare as an interface
#46099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/properly-add-accept-share-interface
branch
from
e3d9d6d
to
a9e8ea8
Compare
come-nc
approved these changes
Jul 2, 2024
susnux
requested review from
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
Merged
susnux
force-pushed
the
fix/properly-add-accept-share-interface
branch
from
a9e8ea8
to
393f44f
Compare
skjnldsv
approved these changes
Jul 30, 2024
susnux
force-pushed
the
fix/properly-add-accept-share-interface
branch
from
393f44f
to
d1237d6
Compare
nickvergessen
approved these changes
Jul 30, 2024
It was commented out because at that time no other share provider supported the `acceptShare` method. Today it is the same no other provider supports it, but we should make it discoverable by adding it to the public API as an additional interface. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/properly-add-accept-share-interface
branch
from
d1237d6
to
3d136e4
Compare
|
Forgot to add the autoload stuff... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was commented out because at that time no other share provider supported the
acceptSharemethod. Today it is the same no other provider supports it, but we should make it discoverable by adding it to the public API as an additional interface.5 years after no other provider supports it, so maybe an additional interface would be better like done here?
Ref: #16828 (comment)
Checklist