Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow getting/setting the password hash of a user #46123

Merged
merged 6 commits into from
Jul 9, 2024
Merged

feat: Allow getting/setting the password hash of a user #46123

merged 6 commits into from
Jul 9, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 25, 2024 •
edited
Loading

Summary

  • Allows getting/setting the password hash of a given user

Checklist

@Pytal Pytal added this to the Nextcloud 30 milestone Jun 25, 2024
@Pytal Pytal self-assigned this Jun 25, 2024
This was referenced Jun 25, 2024
Merged
Merged
@icewind1991

This comment was marked as resolved.

Sign in to view
come-nc

This comment was marked as resolved.

Sign in to view

@Pytal

This comment was marked as resolved.

Sign in to view
@Pytal Pytal force-pushed the feat/user-password-hash branch 2 times, most recently from 481eb3e to a0662ad Compare July 5, 2024 01:15
@Pytal Pytal requested review from come-nc and yemkareems July 5, 2024 01:16
@Pytal Pytal mentioned this pull request Jul 5, 2024
Merged
@Pytal Pytal enabled auto-merge July 5, 2024 22:29
come-nc
come-nc reviewed Jul 8, 2024
View reviewed changes
lib/private/User/Database.php Show resolved Hide resolved
lib/private/User/Database.php Outdated Show resolved Hide resolved
lib/private/User/User.php Outdated Show resolved Hide resolved
lib/private/User/User.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jul 8, 2024
@Pytal Pytal mentioned this pull request Jul 8, 2024
Merged
Pytal added 5 commits July 8, 2024 16:30
@Pytal
feat: Add IPasswordHashBackend
69f252a 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat: Implement IPasswordHashBackend in database user backend
a330f4c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat: Allow getting/setting the password hash of a user
34d97d4 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
docs: Add info for the password hashes
d65f531 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
perf: Return cached password hash
dba0056 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat: Validate password hash
c390ae9 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal removed the pending documentation This pull request needs an associated documentation update label Jul 8, 2024
@Pytal Pytal merged commit 3a97dbf into master Jul 9, 2024
165 checks passed
@Pytal Pytal deleted the feat/user-password-hash branch July 9, 2024 15:00
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@artonge artonge artonge approved these changes

@come-nc come-nc come-nc approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@yemkareems yemkareems Awaiting requested review from yemkareems

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews enhancement feature: users and groups
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@Pytal @icewind1991 @nickvergessen @artonge @come-nc