Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix "Unknown path" error when source user files folder has not been initialized #46124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 25, 2024

Summary

Calling transfer() with a source user who has not yet logged in will throw an "Unknown path" error. To fix this we initialize the source user filesystem like we do with the destination user.

Checklist

@Pytal Pytal added bug 3. to review Waiting for reviews labels Jun 25, 2024
@Pytal Pytal added this to the Nextcloud 30 milestone Jun 25, 2024
@Pytal Pytal self-assigned this Jun 25, 2024
@Pytal Pytal enabled auto-merge June 25, 2024 23:30
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick, but looks good otherwise 👍

@Pytal Pytal disabled auto-merge June 26, 2024 22:04
@Pytal Pytal force-pushed the fix/ownership-transfer-source-user-files branch from 9492c94 to 92432a2 Compare June 27, 2024 18:49
This was referenced Jul 30, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@Pytal Pytal force-pushed the fix/ownership-transfer-source-user-files branch from b2b5142 to 812280c Compare August 26, 2024 22:38
@Pytal Pytal requested review from a team and yemkareems and removed request for a team August 26, 2024 22:38
@Pytal Pytal enabled auto-merge August 26, 2024 22:38
@AndyScherzinger AndyScherzinger force-pushed the fix/ownership-transfer-source-user-files branch from 812280c to 2b2cc10 Compare September 3, 2024 10:25
… been initialized

Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/ownership-transfer-source-user-files branch from 2b2cc10 to 918a16b Compare September 3, 2024 17:22
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 3, 2024
@Pytal
Copy link
Member Author

Pytal commented Sep 3, 2024

/backport to stable30

@Pytal
Copy link
Member Author

Pytal commented Sep 3, 2024

/backport to stable29

@Pytal
Copy link
Member Author

Pytal commented Sep 3, 2024

/backport to stable28

@Pytal
Copy link
Member Author

Pytal commented Sep 3, 2024

CI failure unrelated

@Pytal
Copy link
Member Author

Pytal commented Sep 5, 2024

"Recent push is still being processed, and will show up in a bit" :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants