refactor: simplify background commands #46185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
kesselb
force-pushed
the
debt/noid/migrate-background-commands-to-iappconfig
branch
2 times, most recently
from
0b43d72
to
270276a
Compare
kesselb
added
2. developing
kesselb
force-pushed
the
debt/noid/migrate-background-commands-to-iappconfig
branch
from
270276a
to
e2860c8
Compare
kesselb
added
3. to review
kesselb
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
reviewed
Jul 1, 2024
|
Good idea! |
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
debt/noid/migrate-background-commands-to-iappconfig
branch
from
23aa62b
to
a773a8b
Compare
artonge
approved these changes
Jul 1, 2024
susnux
approved these changes
Jul 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request was intended to help with #45083 but overlapped with #46009.
The rebased version is now a refactoring merging the three commands for the background mode.
TODO
Checklist