Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(carddav): limit vcard size #46193

Merged
merged 1 commit into from
Jul 4, 2024
Merged

fix(carddav): limit vcard size #46193

merged 1 commit into from
Jul 4, 2024

Conversation

SebastianKrupinski
Copy link
Contributor

@SebastianKrupinski SebastianKrupinski commented Jun 28, 2024 •
edited
Loading

  • Resolves: Card size limit

@tcitworld
Copy link
Member

Ah, this reminds me I never added the repair steps I was talking about here: nextcloud/contacts#2743

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 1, 2024
View reviewed changes
apps/dav/lib/CardDAV/CardDavBackend.php Fixed Show fixed Hide fixed
apps/dav/lib/CardDAV/CardDavBackend.php Fixed Show fixed Hide fixed
apps/dav/lib/CardDAV/CardDavBackend.php Fixed Show fixed Hide fixed
apps/dav/lib/CardDAV/CardDavBackend.php Fixed Show fixed Hide fixed
@SebastianKrupinski
Copy link
Contributor Author

Ah, this reminds me I never added the repair steps I was talking about here: nextcloud/contacts#2743

@tcitworld Are you going to write the repair step? If you are I modified the PR to use a configurable app setting, please use the same setting for the repair step.

st3iny
st3iny approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SebastianKrupinski
fix(carddav): limit vcard size
cb6c091 
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
@st3iny st3iny enabled auto-merge July 4, 2024 20:43
@st3iny st3iny merged commit a8e581c into master Jul 4, 2024
165 checks passed
@st3iny st3iny deleted the fix/limit-vcard-size branch July 4, 2024 22:08
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable27

@backportbot backportbot bot mentioned this pull request Jul 4, 2024
Merged
@SebastianKrupinski
Copy link
Contributor Author

/backport to stable28

@SebastianKrupinski
Copy link
Contributor Author

/backport to stable29

@backportbot backportbot bot mentioned this pull request Jul 4, 2024
Merged
@backportbot backportbot bot mentioned this pull request Jul 4, 2024
Merged
@SebastianKrupinski SebastianKrupinski added this to the Nextcloud 30 milestone Jul 23, 2024
@SebastianKrupinski SebastianKrupinski added the feature: carddav Related to CardDAV internals label Jul 23, 2024
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb left review comments

@st3iny st3iny st3iny approved these changes

@hamza221 hamza221 hamza221 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees
No one assigned
Labels
feature: carddav Related to CardDAV internals
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@SebastianKrupinski @tcitworld @st3iny @kesselb @hamza221