-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add commands for exporting current and expected database schema #46194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from deprecated method call.
6c467c3
to
0681559
Compare
0681559
to
2a1c260
Compare
2a1c260
to
0120a0f
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
0120a0f
to
4f01486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good addition!
$output->writeln($schema->toSql($this->connection->getDatabasePlatform())); | ||
} else { | ||
$encoder = new SchemaEncoder(); | ||
$this->writeArrayInOutputFormat($input, $output, $encoder->encodeSchema($schema, $this->connection->getDatabasePlatform())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add support for iterables in there to some day be able to output while computing when not using json output.
Can be useful when investigating database related issue.