Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same setup-php version on all tests #46197

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jun 28, 2024

Summary

TODO

  • CI

Checklist

@solracsf solracsf added the 2. developing Work in progress label Jun 28, 2024
@solracsf solracsf added this to the Nextcloud 30 milestone Jun 28, 2024
@solracsf solracsf added 3. to review Waiting for reviews CI and removed 2. developing Work in progress labels Jun 28, 2024
@solracsf solracsf changed the title fix(ci): use the same setup-php version on all tests Use the same setup-php version on all tests Jun 28, 2024
@joshtrichards
Copy link
Member

I wonder if it's worth either:

  • using the v2 tag (I get we may not want to let it float to even minor patch version changes to avoid test diffs; though I guess we already have been using inconsistent hashes since we're doing this all manually at the moment)
  • go ahead and use a specific 2.x.y version tag and integrate with dependabot

?

Refs:

@solracsf
Copy link
Member Author

To read also: https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash

@solracsf solracsf requested a review from susnux June 29, 2024 07:27
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@susnux

This comment was marked as resolved.

@solracsf solracsf enabled auto-merge June 30, 2024 06:13
@solracsf solracsf merged commit b77c151 into master Jun 30, 2024
169 checks passed
@solracsf solracsf deleted the setupPhpUpgrade branch June 30, 2024 06:39
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants