Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TaskProcessing): Add more task types #46251

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

marcelklehr
Copy link
Member

Summary

This creates three new task types. One is a chat task type that will make it easier to apply prompt templates for Assistant's LLM Chat interface. The other two are implemented already in llm2 (and also in integration_openai i think), so adding them here, allows to have a canonical definition.

Todo

  • Discuss whether the I/O params are well chosen

Checklist

Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you feel like adding it, we could use a "reformulate" task type as well.

@marcelklehr marcelklehr added enhancement 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels Jul 4, 2024
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr force-pushed the feat/taskprocessing-more-tasktypes branch from d73e8fb to d9cf6e6 Compare July 4, 2024 08:10
@nickvergessen nickvergessen merged commit bd7b09a into master Jul 4, 2024
163 of 165 checks passed
@nickvergessen nickvergessen deleted the feat/taskprocessing-more-tasktypes branch July 4, 2024 12:02
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants