Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] fix(theming): Conitionally disable blur filter for performance #46258

Merged
merged 3 commits into from
Jul 11, 2024
Merged

[stable29] fix(theming): Conitionally disable blur filter for performance #46258

merged 3 commits into from
Jul 11, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 2, 2024 •
edited by susnux
Loading

Backport of #45395

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Jul 2, 2024
@backportbot backportbot bot added this to the Nextcloud 29.0.4 milestone Jul 2, 2024
@susnux susnux marked this pull request as ready for review July 10, 2024 22:32
@susnux
Copy link
Contributor

susnux commented Jul 10, 2024

/backport! to stable28

@backportbot backportbot bot mentioned this pull request Jul 10, 2024
Merged
2 tasks
szaimen
szaimen approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux susnux enabled auto-merge July 10, 2024 23:54
@susnux @AndyScherzinger
fix(theming): Conitionally disable blur filter for performance
eb282a6 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @AndyScherzinger
feat(theming): Add checkbox for force enable / disable blurry background
78114c6 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @AndyScherzinger
chore: Compile assets
914aa98 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux merged commit 1672d79 into stable29 Jul 11, 2024
160 of 175 checks passed
@susnux susnux deleted the backport/45395/stable29 branch July 11, 2024 07:17
@Altahrim Altahrim mentioned this pull request Jul 11, 2024
Merged
@nickvergessen
Copy link
Member

Kind of related, don't you think 🤔
image

@nickvergessen nickvergessen mentioned this pull request Jul 12, 2024
Merged
1 task
@susnux
Copy link
Contributor

susnux commented Jul 12, 2024

Kind of related, don't you think 🤔

It is but why was it merged? I enabled auto merge so it should not merge on error 👀

@susnux susnux mentioned this pull request Jul 12, 2024
Merged
@SystemKeeper
Copy link
Contributor

SystemKeeper commented Jul 12, 2024 •
edited
Loading

I enabled auto merge so it should not merge on error 👀

160 of 175 checks passed

phpunit-nodb-summary seems to be not marked as required? So all required passed -> merge

Edit: At least on stable? It seems it is on master?

@Antreesy Antreesy mentioned this pull request Aug 22, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@szaimen szaimen szaimen approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees

@susnux susnux

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 29.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @nickvergessen @SystemKeeper @szaimen