Fix: Make out of office replacement nullable #46273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or am I missing something and the changes are not breaking because they have never been released so far? |
Yes it was never released |
|
Alright then, just need to properly generate the OpenAPI changes 👍 |
provokateurin
approved these changes
Jul 3, 2024
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
fix/make-ooo-replacement-nullable
branch
from
b61c049
to
85a3b27
Compare
nickvergessen
added
the
pending documentation
| @@ -76,14 +76,14 @@ public function getMessage(): string; | |||
| * | |||
| * @since 30.0.0 | |||
| */ | |||
| public function getReplacementUserId(): string; | |||
| public function getReplacementUserId(): ?string; | |||
There was a problem hiding this comment.
@hamza221 Please document in https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_30.html#id1
(all changes in lib/public/)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
$replacementUserIdandreplacementUserDisplayNamenullableChecklist