Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(userstatus): add missing parenthesis #46287

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

miaulalala
Copy link
Contributor

  • Resolves: #

Summary

Wrap the if conditions in the correct parenthesis

TODO

  • ...

Checklist

@miaulalala miaulalala added the 3. to review Waiting for reviews label Jul 3, 2024
@miaulalala miaulalala added this to the Nextcloud 30 milestone Jul 3, 2024
@miaulalala miaulalala self-assigned this Jul 3, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable29

@miaulalala
Copy link
Contributor Author

/backport to stable28

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a test have found this?

@miaulalala miaulalala force-pushed the fix/noid/missing-parentheses branch from 3bfdad4 to 8a36fe4 Compare July 8, 2024 13:17
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test 🙏

@miaulalala miaulalala added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 9, 2024
@miaulalala
Copy link
Contributor Author

Already tests covering it, just makes the code a bit more readable in its intention

@miaulalala miaulalala added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 22, 2024
This was referenced Jul 30, 2024
Signed-off-by: Anna Larch <anna@nextcloud.com>
@AndyScherzinger AndyScherzinger merged commit f645c9b into master Aug 1, 2024
161 of 168 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/noid/missing-parentheses branch August 1, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants