Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): wait for apps list fetch for better testing stability #46310

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 4, 2024

Seems to fail randomly sometimes on github/our runners

See #46283 (comment)

image

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement 3. to review Waiting for reviews tests Related to tests labels Jul 4, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jul 4, 2024
@skjnldsv skjnldsv requested review from susnux, a team, Pytal and sorbaugh and removed request for a team July 4, 2024 16:34
@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 4, 2024

/backport to stable29

@skjnldsv
Copy link
Member Author

skjnldsv commented Jul 4, 2024

/backport to stable28

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@skjnldsv skjnldsv requested a review from artonge July 4, 2024 16:50
@skjnldsv skjnldsv enabled auto-merge July 4, 2024 16:54
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@skjnldsv skjnldsv merged commit 99feafa into master Jul 9, 2024
110 checks passed
@skjnldsv skjnldsv deleted the fix/cypress-wait-apps branch July 9, 2024 20:34
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants