Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Correctly center the checkbox's background in grid view #46358

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jul 8, 2024

Background set to red for the screenshots to make it more obvious

Before After
Screenshot from 2024-07-08 17-34-52 Screenshot from 2024-07-08 17-34-30

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge requested a review from skjnldsv as a code owner July 8, 2024 15:35
@artonge artonge self-assigned this Jul 8, 2024
@artonge
Copy link
Contributor Author

artonge commented Jul 8, 2024

/compile /

@artonge artonge added bug 4. to release Ready to be released and/or waiting for tests to finish feature: files javascript labels Jul 8, 2024
@artonge artonge added this to the Nextcloud 30 milestone Jul 8, 2024
@artonge artonge requested a review from susnux July 8, 2024 15:36
@susnux
Copy link
Contributor

susnux commented Jul 8, 2024

Probably the background should be added to the component directly?

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AndyScherzinger AndyScherzinger merged commit 9b2d195 into master Jul 8, 2024
110 checks passed
@AndyScherzinger AndyScherzinger deleted the artonge/fix/checkbox_background branch July 8, 2024 19:12
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants