TaskProcessing follow-up #46368
Merged
TaskProcessing follow-up #46368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bigcat88
reviewed
Jul 9, 2024
| * Use field 'file' for the file upload | ||
| * | ||
| * @param int $taskId The id of the task | ||
| * @return DataResponse<Http::STATUS_CREATED, array{fileId: int}, array{}>|DataResponse<Http::STATUS_INTERNAL_SERVER_ERROR|Http::STATUS_NOT_FOUND, array{message: string}, array{}> |
Check failure
Code scanning / Psalm
InvalidReturnType Error
| $task = $this->taskProcessingManager->getTask($taskId); | ||
| $file = $this->request->getUploadedFile('file'); | ||
| if (!isset($file['tmp_name'])) { | ||
| return new DataResponse(['message' => $this->l->t('Bad request')], Http::STATUS_BAD_REQUEST); |
Check failure
Code scanning / Psalm
InvalidReturnStatement Error
| return new DataResponse(['message' => $this->l->t('Bad request')], Http::STATUS_BAD_REQUEST); | ||
| } | ||
| $data = file_get_contents($file['tmp_name']); | ||
| if (!$data) { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison Note
marcelklehr
force-pushed
the
fix/task-processing
branch
from
08375ad
to
081eed7
Compare
marcelklehr
commented
Jul 13, 2024
| $task = $this->taskProcessingManager->getTask($taskId); | ||
| $file = $this->request->getUploadedFile('file'); | ||
| if (!isset($file['tmp_name'])) { | ||
| return new DataResponse(['message' => $this->l->t('Bad request')], Http::STATUS_BAD_REQUEST); |
Check failure
Code scanning / Psalm
InvalidReturnStatement Error
| @@ -493,4 +529,15 @@ | |||
| return new DataResponse(['message' => $this->l->t('Internal error')], Http::STATUS_INTERNAL_SERVER_ERROR); | |||
| } | |||
| } | |||
|
|
|||
| private function setFileContentsInternal($data): int { | |||
Check notice
Code scanning / Psalm
MissingParamType Note
marcelklehr
force-pushed
the
fix/task-processing
branch
2 times, most recently
from
58ad083
to
369681f
Compare
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Differentiate between output with file IDs and output with File data Signed-off-by: Marcel Klehr <mklehr@gmx.net>
…h ID instead of File object Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Alexander Piskun <bigcat88@icloud.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
…h ID instead of File object Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
… names Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
…tegers Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/task-processing
branch
from
369681f
to
6ff4524
Compare
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
julien-nc
approved these changes
Jul 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pick up and solve lose ends in TaskProcessing
Checklist