fix(files): Add rounded corners back in grid view #46373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/fix/rounded_corner_in_grid_view
branch
from
9ac6d38
to
54f48d3
Compare
jancborchardt
requested changes
Jul 10, 2024
There was a problem hiding this comment.
var(--border-radius) for the image preview itself looks good, but the outside element (the hover/focus background) should have a bigger radius to match, so best use var(--border-radius-large) for that.
This is the same how it is in the action menus for example.
artonge
force-pushed
the
artonge/fix/rounded_corner_in_grid_view
branch
from
54f48d3
to
9ebac30
Compare
|
Updated |
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/rounded_corner_in_grid_view
branch
from
9ebac30
to
5fc79e4
Compare
susnux
approved these changes
Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was removed intentionally due to mockups.