Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make app icons consistent Material Symbols with same settings #46391

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 10, 2024

Summary

Make all app icons the same style Material Symbols (e.g. files was still MDI, and some had different optical size).

Checklist

@susnux susnux added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jul 10, 2024
@susnux susnux added this to the Nextcloud 30 milestone Jul 10, 2024
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor changes suggested

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the chore/use-consistent-material-symbols branch from 8c56c44 to b2cf056 Compare July 10, 2024 13:53
@susnux
Copy link
Contributor Author

susnux commented Jul 10, 2024

Potential follow up:
There seem to be quite some images we do not use anymore and possibly can remove.
Also the weather status has some other icons that we could migrate to Material Symbols (they provide all kind of weather icons).

@AndyScherzinger
Copy link
Member

Let's merge it than as-is right now, to have it deployed.

Replacing weather icons with material would be nice in case there actually are variants for all cases.

@susnux susnux merged commit b97c7df into master Jul 10, 2024
125 checks passed
@susnux susnux deleted the chore/use-consistent-material-symbols branch July 10, 2024 17:47
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants