feat: don't count failed CSRF as failed login attempt #46392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
added
enhancement
3. to review
|
/backport to stable29 |
|
/backport to stable28 |
Altahrim
requested review from
nickvergessen,
ChristophWurst,
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
nickvergessen
approved these changes
Jul 10, 2024
Altahrim
force-pushed
the
chore/bruteforce-dont-count-failed-csrf
branch
2 times, most recently
from
07e353d
to
8e28582
Compare
Altahrim
force-pushed
the
chore/bruteforce-dont-count-failed-csrf
branch
from
8e28582
to
916e091
Compare
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Altahrim
force-pushed
the
chore/bruteforce-dont-count-failed-csrf
branch
from
916e091
to
e5275db
Compare
yemkareems
approved these changes
Jul 11, 2024
This was referenced Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't count failed CSRF as a failed login attempt
Checklist