fix: set default TTL for APCu cache as per docs #46395
Merged
+26
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
nickvergessen,
juliusknorr,
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sorbaugh
approved these changes
Jul 10, 2024
nickvergessen
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
Couple thoughts:
- Should we do this for
incanddectoo? e.g. https://www.php.net/manual/en/function.apcu-inc.php - Should we adjust the logging wrapper to include the ttl at the same time?
- Probably out of scope, but may also be an opportunity clean-up the no longer needed code for an early PHP 7 bug in
inc&deca bit farther down
icewind1991
force-pushed
the
apcu-default-ttl
branch
from
7231ef5 to
8a5ecb3
Compare
|
ChristophWurst
approved these changes
Jul 11, 2024
Altahrim
approved these changes
Jul 11, 2024
Seems the documentation is also different. |
juliusknorr
approved these changes
Jul 11, 2024
Merged
icewind1991
force-pushed
the
apcu-default-ttl
branch
from
97b2ce7 to
d6640cc
Compare
Merged
icewind1991
force-pushed
the
apcu-default-ttl
branch
from
d6640cc to
58a4982
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…e interface Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
apcu-default-ttl
branch
from
58a4982 to
5490b12
Compare
|
This is causing troubles on v30: #48007 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the method behavior match the description