feat: allow inspecting the parts of the composite expression builder #46396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
yemkareems,
sorbaugh,
artonge and
come-nc
and removed request for
a team
icewind1991
force-pushed
the
inspectable-composite-expression
branch
from
b6c33a6
to
c2c1817
Compare
come-nc
approved these changes
Jul 11, 2024
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
inspectable-composite-expression
branch
from
c2c1817
to
d81d59e
Compare
artonge
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBAL's
CompositeExpressiondoesn't allow getting the parts of the expression for introspection.This replaces the logic of the
CompositeExpressionwith a custom so that our code can inspect the expression.Extracted from, and needed for the sharding work.