Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Close sidebar on navigation #46432

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix(files): Close sidebar on navigation #46432

merged 2 commits into from
Jul 15, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jul 10, 2024

Summary

When navigating to another folder the sidebar is now closed.

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Jul 10, 2024
szaimen
szaimen approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works but didnt review the code

@susnux
Copy link
Contributor Author

susnux commented Jul 11, 2024

/compile rebase

@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 11, 2024
@susnux
Copy link
Contributor Author

susnux commented Jul 11, 2024

/backport to stable29

@susnux
fix(files): Close the sidebar on navigation
841efff 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
c5f9ab9 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/close-sidebar-on-navigation branch from bd03722 to c5f9ab9 Compare July 15, 2024 09:43
@susnux susnux merged commit d428498 into master Jul 15, 2024
111 checks passed
@susnux susnux deleted the fix/close-sidebar-on-navigation branch July 15, 2024 10:53
@backportbot backportbot bot mentioned this pull request Jul 15, 2024
Merged
2 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
@susnux
Copy link
Contributor Author

susnux commented Aug 2, 2024

/backport to stable28

@backportbot backportbot bot mentioned this pull request Aug 2, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Details tab not closing / shows details for previous folder selected when browsing to another location
4 participants
@susnux @artonge @skjnldsv @szaimen