feat(editLocallyAction): Handle possible no local client scenario #46452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
reviewed
Jul 11, 2024
susnux
reviewed
Jul 11, 2024
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
8 times, most recently
from
a113d41
to
c45e176
Compare
Fenn-CS
requested review from
a team,
Pytal and
sorbaugh
and removed request for
a team
Fenn-CS
added
3. to review
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
3 times, most recently
from
ce7055b
to
0ef4ad3
Compare
Pytal
reviewed
Jul 12, 2024
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
from
0ef4ad3
to
43aade3
Compare
Pytal
reviewed
Jul 15, 2024
| .then(() => { | ||
| // Ensure the callback is called even if the dialog is dismissed in other ways | ||
| if (!callbackCalled) { | ||
| localEditCallback(true) |
There was a problem hiding this comment.
IMO closing the dialog should have the same effect as cancelling
There was a problem hiding this comment.
I thought so too, but I was like maybe it's better to just proceed with action the user was attempting to do in the first place if they are clicking outside the modal?
There was a problem hiding this comment.
I don't have any strong feeling about this, any is fine for me.
Pytal
reviewed
Jul 15, 2024
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
from
43aade3
to
9ad0a2b
Compare
Pytal
approved these changes
Jul 16, 2024
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
from
9ad0a2b
to
038b40b
Compare
skjnldsv
approved these changes
Jul 16, 2024
|
/compile / |
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
2 times, most recently
from
0b526e1
to
0274821
Compare
|
/compile / |
|
@Fenn-CS can you fix the test please? |
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
from
4578636
to
d22fe6e
Compare
Resolves: #46438 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
2 times, most recently
from
50110c6
to
08df57e
Compare
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
feat/46438/provide-feedback-edit-locally
branch
from
08df57e
to
efcf98d
Compare
|
/compile / |
|
/backport to stable29 |
|
/backport to stable28 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Jul 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves: #46438
Screencast
Screencast.from.2024-07-12.01-43-50.webm
TODO