feat(theming): Allow shipped backgrounds to have a dark variant #46453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
design
AndyScherzinger
approved these changes
Jul 11, 2024
|
Nice work @susnux 👍 |
susnux
force-pushed
the
feat/background-with-dark-variant
branch
from
cd54f0c
to
b21ec91
Compare
sorbaugh
approved these changes
Jul 11, 2024
susnux
force-pushed
the
feat/background-with-dark-variant
branch
from
b21ec91
to
c3edc53
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
feat/background-with-dark-variant
branch
from
c3edc53
to
d5dc6b2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add the new default backgrounds with dark and light variants depending on color schema.
This also allows future shipped backgrounds to define a dark variant (and with minor adjustments probably we can also support custom ones).
vokoscreenNG-2024-07-11_15-00-30.webm
Checklist