Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): Require version >=4 for unlink #46475

Merged
merged 1 commit into from
Jul 15, 2024
Merged

fix(redis): Require version >=4 for unlink #46475

merged 1 commit into from
Jul 15, 2024

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jul 12, 2024

Summary

v4+ (released 7y ago...) is required for unlink

if ($this->getCache()->unlink($this->getPrefix() . $key)) {

Checklist

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added the 3. to review Waiting for reviews label Jul 12, 2024
@solracsf solracsf added this to the Nextcloud 30 milestone Jul 12, 2024
@solracsf
Copy link
Member Author

/backport to stable29

@solracsf
Copy link
Member Author

/backport to stable28

@solracsf solracsf requested review from a team, ArtificialOwl, nfebe, yemkareems, nickvergessen, blizzz and kesselb and removed request for a team July 12, 2024 17:57
@solracsf solracsf enabled auto-merge July 12, 2024 18:32
@solracsf solracsf merged commit fcff64a into master Jul 15, 2024
166 checks passed
@solracsf solracsf deleted the redisReqVer4 branch July 15, 2024 07:54
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jul 15, 2024
@nickvergessen
Copy link
Member

nickvergessen commented Jul 15, 2024

Should add that to https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/caching_configuration.html ?

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants