feat: webhooks_listeners app: send direct requests to ExApps using AppAPI #46477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $statusCode = $response->getStatusCode(); | ||
| if ($statusCode >= 200 && $statusCode < 300) { | ||
| $this->logger->debug('Webhook returned status code '.$statusCode, ['body' => $response->getBody()]); | ||
| } else { | ||
| $this->logger->warning('Webhook returned unexpected status code '.$statusCode, ['body' => $response->getBody()]); | ||
| $this->logger->warning('Webhook(' . $webhookId . ') returned unexpected status code '.$statusCode, ['body' => $response->getBody()]); |
Check notice
Code scanning / Psalm
PossiblyInvalidMethodCall Note
marcelklehr
approved these changes
Jul 15, 2024
…xApps using AppAPI. Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
force-pushed
the
support-direct-appapi-requests
branch
from
460723d
to
696ece2
Compare
bigcat88
added
4. to release
bigcat88
added a commit
to cloud-py-api/nc_py_api
that referenced
this pull request
Jul 19, 2024
Not finished yet, because... I'm waiting for this to be finalized on the server. The technology is very powerful, probably better than what happened with ExApp. It can also be used as a Nextcloud client, but the client must have administrator access. Some docs(and maybe article?) will come before NC30 release. Reference: nextcloud/server#46477 --------- Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Merged
come-nc
reviewed
Jul 30, 2024
Comment on lines
+143
to
+146
|
|
||
| public function getAppId(): ?string { | ||
| return $this->appId; | ||
| } |
There was a problem hiding this comment.
You do not need to add the method, it’s a DB entity there is a magic method for this already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discussed at the last brainstorm on the WorkflowEngine project:
To improve performance, WebhookApp should directly call ExApp through the AppAPI function.
I made it happen if the webhook URL starts with "/" and the
appIdfield is filled(this field is only filled if webhook is registered by the ExApp).Checklist