Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(settings/admin/ai): Add Task Processing API settings #46509

Merged
merged 5 commits into from
Jul 17, 2024
Merged

feat(settings/admin/ai): Add Task Processing API settings #46509

merged 5 commits into from
Jul 17, 2024

Conversation

marcelklehr
Copy link
Member

Summary

Adds the settings UI for the TaskProcessing API

Todo

  • Discuss whether we want to have a do not offer this task option

Checklist

@marcelklehr marcelklehr force-pushed the feat/settings/taskprocessing branch 2 times, most recently from 2d78596 to e39bf4a Compare July 15, 2024 06:43
@marcelklehr
Copy link
Member Author

image

kyteinsky
kyteinsky approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bigcat88
Copy link
Member

am I understand right that this page will list all available registered task types?

@marcelklehr
Copy link
Member Author

marcelklehr commented Jul 15, 2024 •
edited
Loading

am I understand right that this page will list all available registered task types?

yes, all task types that a provider is installed for

julien-nc
julien-nc approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. Could you check if this issue was not reintroduced?

@julien-nc julien-nc force-pushed the feat/settings/taskprocessing branch from 18f2813 to 5907662 Compare July 17, 2024 09:06
@julien-nc
Copy link
Member

  • Rebased on master
  • Set min-width for the selects to 350px
  • Compiled the assets

@marcelklehr
Copy link
Member Author

Could you check if #43993 was not reintroduced?

It was not afaict

marcelklehr and others added 5 commits July 17, 2024 15:24
@marcelklehr @julien-nc
feat(settings/admin/ai): Add Task Processing API settings
9dca5ae 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@julien-nc
feat(settings/admin/ai): increase min width of provider selects
e312776 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
feat(settings/admin/ai): compile assets
49e5399 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
feat(settings/admin/ai): fix tests
d37dd4b 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc
feat(settings/admin/ai): fix provider list not being declared
183726a 
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
@julien-nc julien-nc force-pushed the feat/settings/taskprocessing branch from 8e4eb84 to 183726a Compare July 17, 2024 13:24
@julien-nc
Copy link
Member

@marcelklehr Can you check my fix in the last commit? 183726a

@marcelklehr
Copy link
Member Author

Looks good

@marcelklehr marcelklehr merged commit 7cb67c6 into master Jul 17, 2024
166 checks passed
@marcelklehr marcelklehr deleted the feat/settings/taskprocessing branch July 17, 2024 16:24
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyteinsky kyteinsky kyteinsky approved these changes