Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_external): Drop deprecated BinaryFinder for smbclient #46516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(files_external): Drop deprecated BinaryFinder for smbclient #46516

wants to merge 1 commit into from

Conversation

joshtrichards
Copy link
Member

Summary

Swap smbclient binary search to OCP\IBinaryFinder / drop use of deprecated OC_Helper method

TODO

Checklist

@joshtrichards
fix(files_external): Drop deprecated BinaryFinder for smbclient
75eba03 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 30 milestone Jul 14, 2024
@susnux susnux added the bug label Jul 25, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2. developing Work in progress bug technical debt
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@joshtrichards @susnux @skjnldsv