Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): drop unwanted RemoteException class #46550

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

skjnldsv
Copy link
Member

Fix #44719

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels Jul 16, 2024
@skjnldsv skjnldsv added this to the Nextcloud 30 milestone Jul 16, 2024
@skjnldsv skjnldsv requested review from come-nc and a team July 16, 2024 06:31
@skjnldsv skjnldsv self-assigned this Jul 16, 2024
@skjnldsv skjnldsv requested review from ArtificialOwl and Fenn-CS and removed request for a team July 16, 2024 06:31
@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

remote.php Fixed Show fixed Hide fixed
@come-nc
Copy link
Contributor

come-nc commented Jul 30, 2024

From what I can see the exception is never caught, you can directly throw \Exception instead? That would avoid confusing psalm with having the same class name in 2 files.

@skjnldsv skjnldsv force-pushed the fix/missing-RemoteException-class branch 2 times, most recently from 910c2c0 to 237576d Compare July 30, 2024 10:10
@skjnldsv
Copy link
Member Author

done @come-nc
Took the opportunity to add more comments to the file

@skjnldsv skjnldsv force-pushed the fix/missing-RemoteException-class branch from 237576d to 887950a Compare July 30, 2024 10:12
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv changed the title fix: add missing RemoteException class fix(dav): drop unwanted RemoteException class Jul 30, 2024
@skjnldsv skjnldsv force-pushed the fix/missing-RemoteException-class branch from 887950a to 0e88e06 Compare July 30, 2024 10:12
@skjnldsv skjnldsv requested review from susnux and artonge July 30, 2024 10:12
@blizzz blizzz mentioned this pull request Jul 30, 2024
@skjnldsv skjnldsv enabled auto-merge July 31, 2024 06:24
@blizzz blizzz mentioned this pull request Aug 1, 2024
@skjnldsv skjnldsv merged commit 60b9bb4 into master Aug 1, 2024
169 checks passed
@skjnldsv skjnldsv deleted the fix/missing-RemoteException-class branch August 1, 2024 13:37
Copy link

backportbot bot commented Aug 1, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/46550/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 0e88e066

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46550/stable28

Error: Failed to push branch backport/46550/stable28: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Class "RemoteException" not found
3 participants