Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appstore): Return an empty array in case of fail #46555

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

solracsf
Copy link
Member

Fix #46552

Summary

If the fetch fail, $apps will be falsy.

Checklist

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added the 3. to review Waiting for reviews label Jul 16, 2024
@solracsf solracsf added this to the Nextcloud 30 milestone Jul 16, 2024
@nickvergessen
Copy link
Member

Should have another log then in place?

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf
Copy link
Member Author

@nickvergessen log has been added.

@solracsf solracsf enabled auto-merge July 17, 2024 09:56
@solracsf
Copy link
Member Author

/backport to stable29

@solracsf
Copy link
Member Author

/backport to stable28

@solracsf solracsf merged commit b06ce83 into master Jul 17, 2024
166 checks passed
@solracsf solracsf deleted the emptyArrayAppStoreFail branch July 17, 2024 10:33
@blizzz blizzz mentioned this pull request Jul 24, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Appstore: Exception array_map(): Argument #2 ($array) must be of type array, null given
3 participants