refactor: Migrate some legacy and core functions to IFilenameValidator
#46571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
3 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
force-pushed
the
chore/migrate-to-filenamevalidator
branch
2 times, most recently
from
3391efc
to
e323421
Compare
susnux
commented
Jul 17, 2024
| @@ -189,8 +189,7 @@ public function postAvatar(?string $path = null): JSONResponse { | |||
| } elseif (!is_null($files)) { | |||
| if ( | |||
| $files['error'][0] === 0 && | |||
| is_uploaded_file($files['tmp_name'][0]) && | |||
| !\OC\Files\Filesystem::isFileBlacklisted($files['tmp_name'][0]) | |||
There was a problem hiding this comment.
No need to check here as this is auto generated
Altahrim
approved these changes
Jul 17, 2024
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
chore/migrate-to-filenamevalidator
branch
from
e323421
to
9716b0d
Compare
yemkareems
approved these changes
Jul 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some more functions that can be migrated to the new validator instead of using private API.
Checklist